GitHub

👀 While it's loading, feel free to check out the other repositories:

🔔 To get a notification when it's ready, leave your email here:

By entering your email, you agree to receive notifications and marketing-related emails

Filter by reset
8332 results 8 ms in manticoresoftware/manticoresearch

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 /sql endpoint returns the exact reply from buddy wrapped into array we could change that but when multi queries will not work - maybe it needs another buddy replication protocol improvement

tomatologtomatolog · 2024-02-08

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 I think, it would be enough to implement a unified format just for insert/replace/update/delete endpoints. As the problem with OpenAPI clients seems to affect only error responses from those ones. So we won't need to change the current handling of /sql or …

Nick-S-2018Nick-S-2018 · 2024-02-09

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 As discussed, please provide more info on how the queries are executed (i.e. what Buddy receives/returns)

sanikolaevsanikolaev · 2024-02-13

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 It looks like it was assigned to Nick by mistake. Reassigning to @tomatolog to estimate.

sanikolaevsanikolaev · 2024-02-14

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 This issue blocks https://github.com/manticoresoftware/openapi/issues/16

sanikolaevsanikolaev · 2024-04-01

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 fixed at the https://github.com/manticoresoftware/manticoresearch/tree/doc_post_error branch as I changed error format for insert/replace/update/delete HTTP JSON endpoints to be the same as it is in the compatibility mode, ie has error object with the …

tomatologtomatolog · 2024-04-04

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 I'd also add different types of error.type as now all insert/replace/update/delete returns only parse_exception and runtime error action_request_validation_exception but that is a large change and I'd add it after the branch got merged into master

tomatologtomatolog · 2024-04-04

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 Waiting for https://github.com/manticoresoftware/manticoresearch/issues/1810 and https://github.com/manticoresoftware/manticoresearch/issues/1866 to be completed before we can merge this one into the master branch.

sanikolaevsanikolaev · 2024-04-16

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 Waiting for https://github.com/manticoresoftware/manticoresearch/issues/1810 and https://github.com/manticoresoftware/manticoresearch/issues/1866 to be completed before we can merge this one into the master branch. Unblocked.

sanikolaevsanikolaev · 2024-05-15

Daemon returns different formats of error message

Nick-S-2018Nick-S-2018 · 2024-05-20 · 10 · #1808

est::size_S

 I've tested it with the doc_post_error branch - it appears that the response format is always {"error":"Some error message"} without Buddy now.

Nick-S-2018Nick-S-2018 · 2024-05-20

Extended quote and double quote functionality

anStalfanStalf · 2024-05-20 · 1 · #2133

est::NO_ESTIMATE

 Supporting double quotes for inserts is not a big deal (probably just a one-line change). Supporting it in other cases (e.g. where match and string comparison) requires more work and better thinking. We need to decide whether we want to support double …

sanikolaevsanikolaev · 2024-05-20

🆕 Update buddy version

githubmanticoregithubmanticore · 2024-05-20 · 3 · #2203

Linux debug test results    10 files   10 suites   8m 15s :stopwatch:   995 tests 944 :white_check_mark: 49 :zzz: 2 :x: 1 009 runs  958 :white_check_mark: 49 :zzz: 2 :x: For more details on these failures, see this check. Results for commit 01e44df0.

github-actions[bot]github-actions[bot] · 2024-05-20

🆕 Update buddy version

githubmanticoregithubmanticore · 2024-05-20 · 3 · #2203

Linux release test results    10 files   10 suites   6m 23s :stopwatch:   995 tests 944 :white_check_mark: 49 :zzz: 2 :x: 1 009 runs  958 :white_check_mark: 49 :zzz: 2 :x: For more details on these failures, see this check. Results for commit 01e44df0.

github-actions[bot]github-actions[bot] · 2024-05-20

🆕 Update buddy version

githubmanticoregithubmanticore · 2024-05-20 · 3 · #2203

Windows test results   3 files    3 suites   17m 51s :stopwatch: 971 tests 920 :white_check_mark: 49 :zzz: 2 :x: 975 runs  924 :white_check_mark: 49 :zzz: 2 :x: For more details on these failures, see this check. Results for commit 01e44df0.

github-actions[bot]github-actions[bot] · 2024-05-20

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 @maximium Thanks for bringing this to our attention and for the PR. @Nick-S-2018 pls review the PR.

sanikolaevsanikolaev · 2024-04-30

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 @maximium The reason why Thai chars are currently in 'cjk' is that our 'cjk' charset, in fact, comprises the languages which don't use spaces between words. We've done that to help users to deal with setting ngram_chars for such languages. @sanikolaev It …

Nick-S-2018Nick-S-2018 · 2024-05-03

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 @sanikolaev It appears that the optimal solution is to move the Thai script to a separate charset that can be used along with cjk and non_cjk. Indeed. The problem with having thai in cjk is tokenizing every letter as a word, which is not correct and gives …

maximiummaximium · 2024-05-03

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 We've added a new thai charset for the corresponding Thai script and renamed the cjk and non_cjk charset names to cont (continuous) and non_cont (non-continuous), respectively, to convey their meaning in a better way (see, https://en.wikipedia.org/wiki/ …

Nick-S-2018Nick-S-2018 · 2024-05-08

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 Now we need to update the respective parts of our code and tests to match these changes: thai_charset What's important is to make sure the older names are still accessible as aliases to the new ones (or vice versa).

sanikolaevsanikolaev · 2024-05-08

Thai chars are in the wrong charsets

maximiummaximium · 2024-05-20 · 8 · #2103

bugest::size_S

 @Nick-S-2018 I don't quite understand the idea of what's done in the PR: are cjk and cont going to be fully identical? should the thai charset be left in both or are we going to leave it in cont , but remove from cjk ? But they can't be aliases then.

sanikolaevsanikolaev · 2024-05-13