Filter by reset
- Everywhere
300 - Issues
30 - Pull Requests
94 - Comments
176
Adapt the code and tests to KNN and fix SKIP issue
We've encountered broken tests in the backup following a change in the official Docker image. Additionally, there's an issue with KNN, and the backup failed to retrieve the versions. We also need to include the KNN version in the versions.json file and โฆ
Wrong ownership after installation in Debian/Ubuntu
When you install manticore-backup in Debian/Ubuntu under root the ownership looks like this: root@78c483766894:/backup# ls -la usr/share/manticore/modules/manticore-backup/ total 104 drwxr-xr-x 4 1001 123 4096 Aug 4 08:41 . drwxr-xr-x 3 1001 123 4096 Aug โฆ
est::size_M
sudo manticore-backup --config=conf --backup-dir=/path/to/search/idx.backup Copyright (c) 2023, Manticore Software LTD (https://manticoresearch.com/) Manticore config file: /home/user/conf Tables to backup: all tables Backup dir: /path/to/search/idx. โฆ
est::size_S
manticore-backup Failed to send query to the Manticore Search daemon
Update Jul 9 2024 Likely MRE - https://github.com/manticoresoftware/manticoresearch-backup/issues/116#issuecomment-2216597206 Package versions: manticore-backup/jammy,now 1.3.8-24052208-57fc406 all [ัััะฐะฝะพะฒะปะตะฝ, ะฐะฒัะพะผะฐัะธัะตัะบะธ] manticore-buddy/jammy,now 2.3 โฆ
bugest::size_Mrel::upcoming
Improve tests to make sure all table files are backed up
It's turned out .spknn files are not backed up now (because FREEZE doesn't show them). Let's improve the tests to make sure all table files are backed up by comparing the backed up files with the actual table files.
est::size_M
Cannot write to backup directory - "/"
When we restore a backup to the root directory, for example, using --backup-dir=/ , and there's a file in the state directory, we can't restore it because of an error.
If you try to backup in a container of our official docker image, you'll get: root@4cfeb22b0f9e:/var/lib/manticore# manticore-backup --backup-dir=/tmp/ Copyright (c) 2023, Manticore Software LTD (https://manticoresearch.com) Manticore config file: /etc/ โฆ
est::size_S
Can't restore outdated backup cause folder non exist
I faced with interesting behavior. If I created a dump with the old version of Buddy, I can't restore it because I haven't desired path. For example in my dump has files inside /usr/share/manticore/modules/manticore-buddy/vendor/composer/composer/doc/... โฆ
est::size_S
Add absolute path support for restore attr
Now to restore the backup we need to use a nested path consisting from backup-dir and restore attribute: manticore-backup --backup-dir=/tmp --restore=mybackup We need to add absolute path support for restore attr, omitting backup-dir in that case: โฆ
Improve decompression logic on restoring compressed backup
At present, our backup restoration process involves reading the file into memory and decompressing it within the same process. This method can lead to "memory out of limit" errors when dealing with large files. To rectify this, we should adopt a more โฆ
est::size_M
We should store manticore-backup tool version and check major changes on restore. In case if major version different and we have breaking changes we should notify user the same way we do with --force flag
enhancementest::size_S
Dig into issue of CI in backup
After transitioning to the new CLT action and updating our images, we've encountered a peculiar issue that needs to be addressed. The problem is as illustrated in the following screenshot:
Backup fails with dynamic config
Conf manticore.conf #!/bin/sh if [ -z "$BLACKLIST_MODE" ]; then BLACKLIST_MODE=0 fi if [ -z "$QUERY_LOG_TO_STDOUT" ]; then DEBUG_QUERY=0 fi SEARCHD_NLP="" NLP_CONF=/etc/manticoresearch/conf_mount/searchd_include.conf if [ -f "$NLP_CONF" ]; then SEARCHD_ โฆ
bug
Add possibility to backup extra files
First, we need to double-check if we truly need the configuration when restoring. If the answer is yes, we should develop a system that allows us to pass multiple configurations, enabling us to back them all up. The feature should also allow us to add โฆ
https listener prevents from connecting to Manticore Search
If you have this in the config: listen = 9312 listen = 127.0.0.1:9306:mysql listen = 127.0.0.1:9308:http listen = 127.0.0.1:9343:https manticore-backup will fail like this: โ ~ manticore-backup --backup-dir=/tmp/ Copyright (c) 2023, Manticore Software LTD โฆ
bug
config: root@perf ~/repl/1 # ls -la total 140 drwxr-xr-x 3 root root 4096 Mar 28 05:27 . drwxr-xr-x 4 root root 4096 Jan 12 03:53 .. drwxr-xr-x 3 root root 4096 Mar 28 05:27 data -rw-r--r-- 1 root root 189 Mar 28 05:12 manticore1.conf -rw------- 1 root โฆ
bug
can't backup from non-default config
root@perf ~/repl/1 # cat manticore1.conf searchd { listen = 127.0.0.1:20201 listen = 127.0.0.1:20301:mysql log = searchd.log query_log = query.log pid_file = searchd.pid data_dir = data binlog_path = } root@perf ~/repl/1 # manticore-backup --config=/root/ โฆ
bug
fails to backup with relative data_dir
With this config: searchd { listen = 127.0.0.1:20208:http listen = 127.0.0.1:20201 listen = 127.0.0.1:20301:mysql log = searchd.log query_log = query.log pid_file = searchd.pid data_dir = data binlog_path = } manticore-backup fails to backup the instance: โฆ
bug
After latest updates and new test-kit image we have some issues in CI tests. We need to check and fix it.
bug
Add tests to make sure that we able to backup and restore multiple configs
We've added a feature that allows backing up multiple configurations: https://github.com/manticoresoftware/manticoresearch-backup/pull/106 Now, we need to ensure it's working correctly by testing: Backing up multiple configurations is successful. โฆ